Re: RFR: 8203870: ProxyBuilder cannot handle Read-Only List Properties properly [v7]

[Petr Štechmüller]

On Sat, 11 Jul 2026 13:02:59 GMT, Marius Hanl <mh...@openjdk.org> wrote:

>> Petr Štechmüller has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix ProxyBuilder to correctly handle read-only Observable Integer/Float 
>> array with @NamedArg
>
> modules/javafx.fxml/src/main/java/com/sun/javafx/fxml/builder/ProxyBuilder.java
>  line 592:
> 
>> 590:                         strsMap.put(propName, new Getter(m, retType));
>> 591:                     } else if (Map.class.isAssignableFrom(retType) && 
>> argType.length == 0
>> 592:                             && !strsMap.containsKey(propName)) {
> 
> Why is this condition needed (only here?)?

Thanks to this condition it is possible to put all values of a `Map` defined 
inside FXML into a concrete `Map` instance in class. `Map` is not a subtype of 
a `Collection` and same is for `ObservableArray`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3564498950