On Wed, 16 Sep 2026 22:53:56 GMT, Marius Hanl <[email protected]> wrote:
>> JUnit 6.0.0 and 6.1.0 and 6.1.3 is out and we can consider updating to it. >> >> Release Notes: >> https://docs.junit.org/current/release-notes/index.html#release-notes-6.0.0 >> >> Notes: >> - Java 17 is the baseline (so not a problem for us, since we have a higher >> baseline) >> - Deprecation were removed (not a problem, as we don't rely on any) >> - JUnit Vintage Engine is deprecated (not a problem, as we dropped support >> for it a year ago -> JUnit 4) >> >> JUnit 6 now uses a single version number for all dependencies, that is >> platform, jupiter and vintage (which we do not use anymore). That makes >> updating it easier. >> >> Junit 6.1 adds 2 more exciting features we can use: >> - `@DefaultLocale` >> - `@DefaultTimeZone` >> >> Both for changing the specific functionality just for the tests and change >> back to the previous value after. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Marius Hanl has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 17 commits: > > - Merge branch 'master' of https://github.com/openjdk/jfx into junit6-upgrade > - eclipse stuff > - add missing junit-bom-6.1.3.pom > - group junit dependencies > - merge #2 > - merge > - Merge branch 'master' of https://github.com/openjdk/jfx into junit6-upgrade > - junit 6.1.3 > - junit 6.1.2 > - Merge branch 'master' of https://github.com/openjdk/jfx into junit6-upgrade > - ... and 7 more: https://git.openjdk.org/jfx/compare/517a4de7...8663e9e1 Looks good. Left a couple of comments. Interestingly, I found `/base/src/test/java/test/JUnit5Test.java`, which is now outdated. build.gradle line 2076: > 2074: dependencies { > 2075: testImplementation group: "org.apiguardian", name: > "apiguardian-api", version: "${apiguardianVersion}" > 2076: testImplementation group: "org.jspecify", name: "jspecify", > version: "${jspecifyVersion}" Why do we need to explicitly declare a dependency on jspecify is it's a transitive dependency? build.gradle line 2081: > 2079: testImplementation group: "org.junit.jupiter", name: > "junit-jupiter-api", version: "${junitVersion}" > 2080: testImplementation group: "org.junit.jupiter", name: > "junit-jupiter-params", version: "${junitVersion}" > 2081: testRuntimeOnly group: "org.junit.jupiter", name: > "junit-jupiter-engine", version: "${junitVersion}" These dependencies are pulled by `junit-jupiter`, so are redundant. Preexisting, but noting. ------------- PR Review: https://git.openjdk.org/jfx/pull/1925#pullrequestreview-5234273898 PR Review Comment: https://git.openjdk.org/jfx/pull/1925#discussion_r4035712413 PR Review Comment: https://git.openjdk.org/jfx/pull/1925#discussion_r4035811689
