On Fri, 18 Sep 2026 12:14:57 GMT, Kevin Rushforth <[email protected]> wrote:
>> build.gradle line 2081:
>>
>>> 2079: testImplementation group: "org.junit.jupiter", name:
>>> "junit-jupiter-api", version: "${junitVersion}"
>>> 2080: testImplementation group: "org.junit.jupiter", name:
>>> "junit-jupiter-params", version: "${junitVersion}"
>>> 2081: testRuntimeOnly group: "org.junit.jupiter", name:
>>> "junit-jupiter-engine", version: "${junitVersion}"
>>
>> These dependencies are pulled by `junit-jupiter`, so are redundant.
>> Preexisting, but noting.
>
> Please leave them as is for this PR. Even though they seem to not be needed,
> we added the testImplementation for junit-jupiter-params to fix
> [JDK-8296283](https://bugs.openjdk.org/browse/JDK-8296283) for the closed
> build. The closed build pulls independencies using Ivy not Maven central and
> this explicit addition was needed, at least at that time.
Then I suggest adding a comment about their use in the closed build.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1925#discussion_r4046636119
