On Thu, 17 Sep 2026 10:35:10 GMT, Nir Lisker <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 17 commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> junit6-upgrade >> - eclipse stuff >> - add missing junit-bom-6.1.3.pom >> - group junit dependencies >> - merge #2 >> - merge >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> junit6-upgrade >> - junit 6.1.3 >> - junit 6.1.2 >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> junit6-upgrade >> - ... and 7 more: https://git.openjdk.org/jfx/compare/517a4de7...8663e9e1 > > build.gradle line 2081: > >> 2079: testImplementation group: "org.junit.jupiter", name: >> "junit-jupiter-api", version: "${junitVersion}" >> 2080: testImplementation group: "org.junit.jupiter", name: >> "junit-jupiter-params", version: "${junitVersion}" >> 2081: testRuntimeOnly group: "org.junit.jupiter", name: >> "junit-jupiter-engine", version: "${junitVersion}" > > These dependencies are pulled by `junit-jupiter`, so are redundant. > Preexisting, but noting. Please leave them as is for this PR. Even though they seem to not be needed, we added the testImplementation for junit-jupiter-params to fix [JDK-8296283](https://bugs.openjdk.org/browse/JDK-8296283) for the closed build. The closed build pulls independencies using Ivy not Maven central and this explicit addition was needed, at least at that time. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1925#discussion_r4046615827
