On Fri, 18 Sep 2026 07:38:28 GMT, John Hendrikx <[email protected]> wrote:

> > > Interestingly, I found `/base/src/test/java/test/JUnit5Test.java`, which 
> > > is now outdated.
> > 
> > 
> > A safeguard introduced during JUnit5 migration JDK-8274274. I wonder if 
> > this test can be deleted now. @kevinrushforth @hjohn what do you think?
> > Or renamed, since it's merely checks for JUnit5 constructs and 
> > parameterized tests.
> > Or, left alone.
> 
> Feel free to remove that, it was the first ever JUnit 5 test when I 
> introduced JUnit 5, just to see if JUnit 5 tests were working :) Given that 
> we now have many JUnit 5 tests, it is redundant.

I don't mind either way. It can be removed now or later via a cleanup bug.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1925#issuecomment-5729932057

Reply via email to