On Sun, 4 Oct 2026 12:57:23 GMT, Nir Lisker <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move note about supporting lazy evaluation to implNote > > modules/javafx.base/src/main/java/javafx/beans/Observable.java line 47: > >> 45: * <p> >> 46: * These implementations mark themselves as invalid when the first >> invalidation >> 47: * event occurs. They do not generate anymore invalidation events until >> their > > Suggestion: > > * event occurs. They do not generate any more invalidation events until their A minor point: The antecedent of "These implementations" is "All bindings and properties", which might be interpreted as excluding, say, ObservableValueBase. Do you think this is worth clarifying? I'll leave it up to you. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4211708942
