On Wed, 7 Oct 2026 20:36:22 GMT, Kevin Rushforth <[email protected]> wrote:

>> modules/javafx.base/src/main/java/javafx/beans/Observable.java line 47:
>> 
>>> 45:  * <p>
>>> 46:  * These implementations mark themselves as invalid when the first 
>>> invalidation
>>> 47:  * event occurs. They do not generate anymore invalidation events until 
>>> their
>> 
>> Suggestion:
>> 
>>  * event occurs. They do not generate any more invalidation events until 
>> their
>
> A minor point: The antecedent of "These implementations" is "All bindings and 
> properties", which might be interpreted as excluding, say, 
> ObservableValueBase. Do you think this is worth clarifying? I'll leave it up 
> to you.

I clarified it to `The implementations in the JavaFX library` which I think I 
used elsewhere as well

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4226492273

Reply via email to