On Sun, 4 Oct 2026 13:19:00 GMT, Nir Lisker <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move note about supporting lazy evaluation to implNote > > modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java > line 69: > >> 67: * this library mark themselves as invalid when the first invalidation >> event >> 68: * occurs. They do not generate any more invalidation events until their >> value is >> 69: * recomputed and valid again. > > Another hidden implementation note in the same vein as the `Observable` ones. > I missed it in the previous review. Since this is a subclass that is covered > by the `Observable` implementation notes, it might be correct to just remove > it. @hjohn This is the last unaddressed docs comment I had. (https://github.com/openjdk/jfx/pull/1081#discussion_r4177803201) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4231599625
