On Fri, 9 Oct 2026 15:10:21 GMT, Nir Lisker <[email protected]> wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java >> line 69: >> >>> 67: * this library mark themselves as invalid when the first invalidation >>> event >>> 68: * occurs. They do not generate any more invalidation events until >>> their value is >>> 69: * recomputed and valid again. >> >> Another hidden implementation note in the same vein as the `Observable` >> ones. I missed it in the previous review. Since this is a subclass that is >> covered by the `Observable` implementation notes, it might be correct to >> just remove it. > > @hjohn This is the last unaddressed docs comment I had. > (https://github.com/openjdk/jfx/pull/1081#discussion_r4177803201) Yes, I missed this, too. I think @nlisker is right in that the part that starts with "Implementations in this library mark themselves as invalid ..." is covered by the super-interface's implNote. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4234729522
