On Wed, 7 Oct 2026 18:34:29 GMT, Kevin Rushforth <[email protected]> wrote:

> > I could make it public with the accessor pattern.
> 
> Are there any scenarios where some application code may need to call that new 
> method? If not, it's an implementation detail that should be hidden.
> 
> My guess the public `show()` method is all that's needed.

Something like the ContextMenu wouldn't be implementable as a library - because 
public API's are missing.
Especially, one would like to prepare the css of a window before it's shown to 
compute it's size and position.
But this is outside of the PR. It would basically require to provide public 
API's for the methods used  in the PR.
So nothing to change here.

> Specifically, please use git merge master rather than git rebase master next 
> time.

👍

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2215#issuecomment-6193403883

Reply via email to