[ 
https://issues.apache.org/jira/browse/OPENNLP-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078741#comment-13078741
 ] 

Jörn Kottmann edited comment on OPENNLP-239 at 8/3/11 1:33 PM:
---------------------------------------------------------------

I understand the comparison issue and that is why we need to write the case 
flag at the begin of the dictionary. The Dictionary class never supported 
switching of the case after it was created. So just having one final flag per 
dictionary is fine.

StringListWarpper will be made non-static, and the case sensitive flag final. 
We need to change the serialization API a little to support to read and store 
the case flag. And then our issues are solved.

Since Dictionary should be immutable we should think about making the put 
method deprecated. 

      was (Author: joern):
    I understand the comparison issue and that is why we need to write the case 
flag at the begin of the dictionary. The Dictionary class never supported 
switching of the case after it was created. So just having one final flag per 
dictionary is fine.

StringListWarpper will be made non-static, and the case sensitive flag static. 
We need to change the serialization API a little to support to read and store 
the case flag. And then our issues are solved.

Since Dictionary should be immutable we should think about making the put 
method deprecated. 
  
> Case Sensitivie Flag & Custom Tag Dictionary
> --------------------------------------------
>
>                 Key: OPENNLP-239
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-239
>             Project: OpenNLP
>          Issue Type: New Feature
>          Components: Parser
>    Affects Versions: tools-1.5.1-incubating
>            Reporter: mark meiklejohn
>            Assignee: James Kosin
>             Fix For: tools-1.5.2-incubating
>
>
> Unable to set case sensitive flag as per TreebankParser 1.3.1 or use a custom 
> tag dictionary

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to