On Thu, 2009-01-29 at 17:53 +0200, Alex Kanavin wrote: > 2009/1/29 Bastien Nocera <had...@hadess.net>: > >> > Using the same code as openobex for the device discovery, and fixing a > >> > few memleaks in the process. > > Could you point them out?
In the obex-data-server code? that one: - info = g_hash_table_new ((GHashFunc)g_str_hash, (GEqualFunc)g_str_equal); + info = g_hash_table_new_full ((GHashFunc)g_str_hash, (GEqualFunc)g_str_equal, NULL, (GDestroyNotify) g_free); And a few calls to ods_usbobex_free_interfaces() were missing as well. > > I've changed the code to not use the same structures as openobex does > > internally, to avoid such confusion. > > Aah, now I see how this works. I'd use Bus/Device/Interface integers > in the D-Bus API instead of Path though, that's what openobex is going > to provide. It's a path triplet. Tadas can call it ID, or something else. > Now it's up to Tadas if he wants to include all of this, or wait until > the same thing is available directly from openobex. I don't mind either way. But I have the feeling that Tadas will be quicker at bringing this into a release than openobex would be. Feel free to prove me wrong though :) Cheers ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
