Hi, (taking Johan in CC so he knows about your work on osso-gwobex and openobex)
Zitat von "Li, Nami" <n...@qca.qualcomm.com>: > Hi, Hendrik Sattler > I saw your patches in openobex-users mail list about obex over > l2cap. Are you in the linux-bluetooth mail list? No, I am not. But I just looked at http://marc.info/?l=linux-bluetooth&w=2&r=1&s=obex&q=b > Can you kindly view my patches for obex over l2cap? Its subject is > "Bluetooth: FTP and OPP over L2CAP". Some comments on changing the FdOBEX to support other than stream stuff: 1. the "enum obex_transport_format fmt" does not belong to struct obex_transport as it is specific to the fd transport -> struct fdobex_data in lib/fdobex.h 2. move the change in lib/obex_main.c to the fd transport (lib/fdobex.c) 3. move the change in lib/obex.c to the fd transport 4. rename OBEX_MT_* to FDOBEX_MT_* and rename the enum type accordingly 5. you do not really need to adapt the code in glib/, it is most likely going to be dropped Your "PATCH 1/2" depends on "PATCH 2/2", so the order should be reversed (but actually they don't affect the same project). @Johan: Looking at [1], what are the reasons that osso-gwobex is using FdOBEX instead of BtOBEX? > As I wrote and verified the two patches before I saw your patches > this morning, so there are a few collisions. Not really. Your patches use the FdOBEX functionality (and actually change it) to allow giving SEQPACKET sockets to FdOBEX. That's ok when you take the comments above in account. We might even squeeze it into openobex-2.0 if osso-gwobex really needs to use FdOBEX. Else, I would suggest using a custom transport, the new read() callback makes it less painful. HS [1]: http://meego.gitorious.org/maemo-bluetooth/osso-gwobex/blobs/master/src/obex-priv.c ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
