Zitat von Johan Hedberg <johan.hedb...@gmail.com>:

> Hi,
>
> On Wed, Jun 15, 2011, Hendrik Sattler wrote:
>> > Ok. Then you need (a possible updated) patch to use L2CAP, don't you?
>>
>> I must correct myself, you don't. The FdOBEX code will read the full
>> packet without any change, even for SEQPACKET sockets.
>
> I didn't actually test this in practice with openobex, but it looks to
> me like it might do partial reads like the following one in
> obex_data_indication() which when called for the first time only tries
> to read sizeof(obex_common_hdr_t) amount of bytes (msg->data_size is 0):
>
>       actual = obex_transport_read(self, sizeof(*hdr)-msg->data_size);
>
> SEQPACKET sockets will loose remaining data if you don't read the full
> packet at once.

You are right. I only fixed it for the custom transport case, not for  
FdOBEX (which wouldn't work). If we want SEQPACKET support for FdOBEX,  
I would go with a reworked patch. If we don't, then no :-)

HS



------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to