On Fri, May 18, 2012 at 4:15 AM, Andreas Fritiofson <[email protected]> wrote: > On Thu, May 17, 2012 at 3:49 PM, Xiaofan Chen <[email protected]> wrote: >> One of the major thing is Andreas Fritiofson's FTDI mpsse >> patch. It seems to me Peter Stuge's comments seem to >> indicate that mpsse.c needs some more work. On the other >> hand, the patch series seem to be not really interfere other >> things, the only major issue is that I feel the configure >> file names should be changed so as not to confuse the >> existing configure file. > > Most or all of Peter's comments that remained relevant after the > initial discussion have been addressed in the latest patch. I don't > think he has reviewed it again.
I think he has just reviewed the patch. Spen also reviewed. So hopefully the first important patch for your patch series will be get sorted out soon. http://openocd.zylin.com/#/c/451/ > Don't let the red cross stop you from > upvoting if you have tested the patch and would like to see it merged. I agree with you here. > I wouldn't mind having it merged before the release but I'm guessing > it would be best marking it as experimental in NEWS. In that case the > plan could be to polish the driver during 0.7.0 and for 0.8.0 remove > the experimental flag and at the same time mark the ft2232 driver as > deprecated. I support to include this to be merged in 0.6.0 release and label it as "experimental". On the other hand, some other people have send me experimental updates to FT2232 driver (D2xx based) which shows great potential as well. So we will have to wait and see on that front. > The new configure files are in a new subdirectory, that should be > enough. Perhaps there is an autotools way to avoid installing that > directory unless you configure with --enable-ftdi. I could add it if I > knew how. That is one way. I think Freddie's idea to use a different directory name than "ftdi" is a good compromise. -- Xiaofan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
