Hi Antonio, I replied to this via direct mail rather than via the devel list and I suspect that got it put in the "delayed handling" bucket. Below you asked me to upload the patch to review.openocd.org, which I have not been able to do. I tried to get an OpenID registration, but I was unable to find any way to do that. Can you upload the submission for me? The diffs are attached. -John
-----Original Message----- From: Antonio Borneo <borneo.anto...@gmail.com> Sent: Saturday, December 28, 2024 6:29 AM To: Lupien, John <jlup...@draper.com> Cc: Martin Husemann <mar...@netbsd.org>; openocd-devel@lists.sourceforge.net Subject: Re: [EXTERNAL] Re: ctype issue CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On Fri, Dec 27, 2024 at 8:39 PM Lupien, John <jlup...@draper.com> wrote: > > Martin is clearly right! Here are the corrected diffs. Thanks for your patch and your effort to improve OpenOCD. There was an initial patch to fix this issue in https://urldefense.us/v2/url?u=https-3A__review.openocd.org_c_openocd_-2B_6444&d=DwIFaQ&c=m5mye7XjY-PNBUdjUS9G7n0DDGwujM2TWPAftzw2VTE&r=ILTxQ-BydeKdMcD7cBYXJnoLPJ7Afuxo693QbxGGh2g&m=yFkHnaMzuykjzyJ633t2qrOo_IHx18cxWJof7szUx1hur0i8tg_lYYAPHazBug-A&s=MAzV04ky-47hZ_Qw4eh2Z6mgreHW-nDGAdEYppI1sBU&e= but the author never pushed a second version after the remarks in the review. I think we can abandon it and take your new version. Would it be possible for you to upload the patch in OpenOCD gerrit at review.openocd.org ? Regards, Antonio
diffs
Description: diffs
