Thanks, I noticed that space once or twice but did not know it was relevant.
The indentation was a bit strange to begin with, and the lines got to long when I added the casts so I did my best with it, thanks for the cleanup! I approve the patch description and the diff. -John From: Antonio Borneo <borneo.anto...@gmail.com> Sent: Monday, January 6, 2025 11:52 AM To: Lupien, John <jlup...@draper.com> Cc: OpenOCD <openocd-devel@lists.sourceforge.net> Subject: Re: [EXTERNAL] Re: ctype issue CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On Mon, Jan 6, 2025 at 4:57 PM Lupien, John <jlup...@draper.com<mailto:jlup...@draper.com>> wrote: Hi Antonio, These entirely reasonable requests were not difficult to meet. In addition, I did a more exhaustive search of all functions from ctype.h and also fixed the ones that were not triggered by my configuration. The attached patch has the results. As an aside, there Is a difference between uint8_t and unsigned char, on some machines which use non-standard char sizes. Your correction of using (unsigned char) rather than (uint8_t) should work correctly on such systems, where the cast to (uint8_t) might truncate the input. Thanks for making me take a closer look! -John I have pushed it in gerrit as https://review.openocd.org/c/openocd/+/8694<https://urldefense.us/v2/url?u=https-3A__review.openocd.org_c_openocd_-2B_8694&d=DwMFaQ&c=m5mye7XjY-PNBUdjUS9G7n0DDGwujM2TWPAftzw2VTE&r=ILTxQ-BydeKdMcD7cBYXJnoLPJ7Afuxo693QbxGGh2g&m=jTyv8AQqXStIMFKkA9NADx44DENOUoPkLUIpIiZSqtQD-fq2BNkiT22HusDmLLmC&s=wCFTT6n_FpuGlLf3DmJiURIzK1yflkfgRf_JdM2uu1A&e=> I have reworked the indentation and some space at the end of the line to pass checkpatch. It compiles, but I have not tested nor reviewed it. Please let me know if you agree with the commit message. I will change it later, if needed. Thanks, Antonio
