On Mon, Jan 6, 2025 at 4:57 PM Lupien, John <jlup...@draper.com> wrote:
> Hi Antonio, > > These entirely reasonable requests were not difficult > to meet. In addition, I did a more exhaustive search of all > functions from ctype.h and also fixed the ones that were > not triggered by my configuration. > > The attached patch has the results. As an aside, there > > Is a difference between uint8_t and unsigned char, on some > machines which use non-standard char sizes. Your > correction of using (unsigned char) rather than (uint8_t) > should work correctly on such systems, where the cast > to (uint8_t) might truncate the input. > > Thanks for making me take a closer look! > > -John > I have pushed it in gerrit as https://review.openocd.org/c/openocd/+/8694 I have reworked the indentation and some space at the end of the line to pass checkpatch. It compiles, but I have not tested nor reviewed it. Please let me know if you agree with the commit message. I will change it later, if needed. Thanks, Antonio >
