Hi Antonio, These entirely reasonable requests were not difficult to meet. In addition, I did a more exhaustive search of all functions from ctype.h and also fixed the ones that were not triggered by my configuration. The attached patch has the results. As an aside, there Is a difference between uint8_t and unsigned char, on some machines which use non-standard char sizes. Your correction of using (unsigned char) rather than (uint8_t) should work correctly on such systems, where the cast to (uint8_t) might truncate the input. Thanks for making me take a closer look! -John
From: Antonio Borneo <borneo.anto...@gmail.com> Sent: Friday, January 3, 2025 9:35 AM To: Lupien, John <jlup...@draper.com> Cc: OpenOCD <openocd-devel@lists.sourceforge.net> Subject: Re: [EXTERNAL] Re: ctype issue CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On Thu, Jan 2, 2025, 21:46 Lupien, John <jlup...@draper.com<mailto:jlup...@draper.com>> wrote: Hi Antonio, I replied to this via direct mail rather than via the devel list and I suspect that got it put in the "delayed handling" bucket. Hi, not a problem at all. I'm just busy as usual with my inbox exploding. Below you asked me to upload the patch to review.openocd.org<https://urldefense.us/v2/url?u=http-3A__review.openocd.org&d=DwMFaQ&c=m5mye7XjY-PNBUdjUS9G7n0DDGwujM2TWPAftzw2VTE&r=ILTxQ-BydeKdMcD7cBYXJnoLPJ7Afuxo693QbxGGh2g&m=f5kbR-KLS-liEelVQUVtqsRyyN5OrkGKJLcTpAm9u74dpLxCHLc9C4Df7L7LYi37&s=km5ORBrQKF-f6IcQW2tvGUsi6FGhqaq6mzTLth13TtY&e=>, which I have not been able to do. I tried to get an OpenID registration, but I was unable to find any way to do that. Can you upload the submission for me? The diffs are attached. I have tried to apply it to OpenOCD master branch and it fails. I suspect you used some riscv branch not upstream. Would you mind rebasing it on the master branch and adding a reasonable commit message? Also, don't use 'uint8_t' as it is reserved, in OpenOCD, for specific target and adapter data types. Even if it looks a waste of text, please use 'unsigned char'. Regards Antonio
ctypes.patch
Description: ctypes.patch
