1) This needs to be broken up into multiple patches. 2) It looked like lots of error handling was removed rather than added3) Not sure why the mflash code is being changed to use the mg prefix. What is mg supposed to mean? 4) Lots of gratuitous formatting changes. If we want to do these types of changes, please use the uncrustify config file in the root of the source tree. Also, make that a separate patch so we can apply it without hunting for actual code changes.
Rick On May 19, 2009, at 11:22 PM, Øyvind Harboe wrote:
I received this in private email. Obviously it was intended for the list. ---------- Forwarded message ---------- From: unsik Kim <[email protected]> Date: Tue, May 19, 2009 at 10:19 AM Subject: [PATCH] mflash: add mflash configure feature To: Øyvind Harboe <[email protected]> Hello? I attached mflash patch. changed files: src/flash/mflash.c src/flash/mflash.h doc/openocd.texi Add mflash configure feature. Large file write and dump support. Remove unused option from mflash bank command. Improve error handling. Reduce too long lines. Use "mg_" as function prefix. --- Regards, unsik Kim <[email protected]> -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com <mflash-patch.diff>_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
-- Rick Altherr [email protected]"He said he hadn't had a byte in three days. I had a short, so I split it with him."
-- Unsigned
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
