2009/5/21 Rick Altherr <[email protected]>: > > On May 20, 2009, at 12:46 AM, unsik Kim wrote: > >> 2009/5/20 Rick Altherr <[email protected]>: >>> >>> 1) This needs to be broken up into multiple patches. >> >> Good point. I know my patch contains 4 logical and 2 style changes. >> That's my mistake. >> I can make seperate patches but it needs painful time. >> I hope to use this one. Should I seperate patches? If the answer is >> "yes", I'll follow. >> > > Yes, please separate the patches. It makes it much easier to review the > pieces. Ok :) I'll do it. > >>> 2) It looked like lots of error handling was removed rather than added >> >> I only removed target memory write error handling. IMHO, checking >> target's memory >> function (like target->type->write_memory) is too excessive. All the >> mflash IO error >> checked by this patch. >> > > The target memory functions can fail. By catching those failures, it will > be easier to track down if the bug is in the mflash layer or the target > layer. Without them, we'll just be hoping that the mflash layer will detect > the error later on, but we will have lost the information on the original > cause of the error. Also, I'll add error checks.
--- Regards, unsik Kim <[email protected]> _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
