On May 20, 2009, at 12:46 AM, unsik Kim wrote:
2009/5/20 Rick Altherr <[email protected]>:1) This needs to be broken up into multiple patches.Good point. I know my patch contains 4 logical and 2 style changes. That's my mistake. I can make seperate patches but it needs painful time. I hope to use this one. Should I seperate patches? If the answer is "yes", I'll follow.
Yes, please separate the patches. It makes it much easier to review the pieces.
2) It looked like lots of error handling was removed rather than addedI only removed target memory write error handling. IMHO, checking target's memory function (like target->type->write_memory) is too excessive. All the mflash IO error checked by this patch.
The target memory functions can fail. By catching those failures, it will be easier to track down if the bug is in the mflash layer or the target layer. Without them, we'll just be hoping that the mflash layer will detect the error later on, but we will have lost the information on the original cause of the error.
3) Not sure why the mflash code is being changed to use the mg prefix. Whatmg_ is comming from company's name "mGine". Also, u-boot and linux mflashis mg supposed to mean?driver use this prefix. Just for the unity of mflash driver.4) Lots of gratuitous formatting changes. If we want to do these types of changes, please use the uncrustify config file in the root of the source tree. Also, make that a separate patch so we can apply it without huntingfor actual code changes.Same as 1).Rick On May 19, 2009, at 11:22 PM, Øyvind Harboe wrote:I received this in private email. Obviously it was intended for the list. ---------- Forwarded message ---------- From: unsik Kim <[email protected]> Date: Tue, May 19, 2009 at 10:19 AM Subject: [PATCH] mflash: add mflash configure feature To: Øyvind Harboe <[email protected]> Hello? I attached mflash patch. changed files: src/flash/mflash.c src/flash/mflash.h doc/openocd.texi Add mflash configure feature. Large file write and dump support. Remove unused option from mflash bank command. Improve error handling. Reduce too long lines. Use "mg_" as function prefix. --- Regards, unsik Kim <[email protected]> -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com <mflash-patch.diff>_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development-- Rick Altherr [email protected]"He said he hadn't had a byte in three days. I had a short, so I split itwith him." -- Unsigned-- --- Regards, unsik Kim <[email protected]>
-- Rick Altherr [email protected]"He said he hadn't had a byte in three days. I had a short, so I split it with him."
-- Unsigned
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
