> 1) This needs to be broken up into multiple patches. Good point. I know my patch contains 4 logical and 2 style changes. That's my mistake. I can make seperate patches but it needs painful time. I hope to use this one. Should I seperate patches? If the answer is "yes", I'll follow.
> 2) It looked like lots of error handling was removed rather than added I only removed target memory write error handling. IMHO, checking target's memory function (like target->type->write_memory) is too excessive. All the mflash IO error checked by this patch. > 3) Not sure why the mflash code is being changed to use the mg prefix. What > is mg supposed to mean? mg_ is comming from company's name "mGine". Also, u-boot and linux mflash driver use this prefix. Just for the unity of mflash driver. > 4) Lots of gratuitous formatting changes. If we want to do these types of > changes, please use the uncrustify config file in the root of the source > tree. Also, make that a separate patch so we can apply it without hunting > for actual code changes. Same as 1). --- Regards, unsik Kim <[email protected]> _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
