Xiaofan Chen wrote: > >> "+1 Looks good to me, but someone else must approve > >> 0 No score > >> -1 I would prefer that you didn't submit this" > >> > >> If the contributor see a -1 and refer to the above, > >> I do not think it is that encouraging. :-).
Do you already consider that "submit" is the Gerrit term for adding a change into the public repository; in the above it does *not* refer to the contributor sending the change into Gerrit? The text in the labels is what a reviewer is saying to the project, ie. maintainers. What the reviewer is saying to the contributor is the text written as comments both inline within the change and in the general comment field during review. I think the wording makes sense when keeping in mind the terminology and who the receiver of the different pieces of information is, but I do agree that the text labels could be made more clear. //Peter _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
