2012/4/18 Julius Baxter <[email protected]> > On Wed, Apr 18, 2012 at 9:58 AM, Olof Kindgren <[email protected]> > wrote: > > > > > > 2012/4/18 Julius Baxter <[email protected]> > >> > >> > If you think getting rid of so many warnings is worth it, we can get > >> > started > >> > now. For example, I'm getting this warning for the OpenRISC core > >> > included in > >> > ORPSoC2: > >> > > >> > %Warning-DECLFILENAME: > >> > rtl/verilog/or1200/or1200_fpu_intfloat_conv.v:323: > >> > Filename 'or1200_fpu_intfloat_conv' does not match MODULE name: > >> > or1200_fpu_intfloat_conv_except > >> > > >> > Could you move module 'or1200_fpu_intfloat_conv_except' to a new file > >> > called > >> > 'or1200_fpu_intfloat_conv_except'? I've tried that locally and it > works. > >> > Alternatively, that module could be defined as a submodule of the main > >> > one, > >> > but that's only available for SystemVerilog (2005). Do we need to > >> > support > >> > older Verilog standards? > >> > >> Hi Ruben > >> > >> This fix has been applied. > >> > >> Thanks again > >> > >> Julius > >> _______________________________________________ > >> OpenRISC mailing list > >> [email protected] > >> http://lists.openrisc.net/listinfo/openrisc > > > > > > I don't think that was a very good idea. There might be scripts that > points > > out the old filename. Getting rid of warnings is good, but this might > break > > stuff. This patch was one of the reasons that I think we should put out a > > proper release before we change more things. > > That's fine. Breaking things due to organisational updates isn't the > end of the world. > > A release is certainly needed. Fixing things like this before a > release shouldn't be seen as an issue. If you want it in its previous > state, we can snapshot a certain revision of the OR1200 repo and > release that. But I don't want to have patches hanging around and on > my list of things to do, because I will surely forget about them as > time goes on and more things come up. > > Cheers > > Julius >
I agree that it's not good to keep patches lying around. I have forgotten to apply some of my own patches that has been reviewed and acked. One way to make it easier to remember is to record them as bugs in bugzilla and set a target version. I'm not sure if that is a workflow that would suit everyone, but it would at least add some visibility into what is currently being worked on, and what has been forgotten. Tomorrow I'll branch out a rel3 version. That will allow everyone to keep working on the main branch as usual, and allows me to pick out the things that should go into the next proper release. Comments? -- Olof Kindgren ______________________________________________ ORSoC Website: www.orsoc.se Email: [email protected] ______________________________________________ FPGA, ASIC, DSP - embedded SoC design
_______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
