Hi Mohan,
Ack with minor comments.
Regards, Vu
> -----Original Message-----
> From: Mohan Kanakam <mo...@hasolutions.in>
> Sent: Friday, November 2, 2018 2:08 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
> <mo...@hasolutions.in>
> Subject: [PATCH 3/3] imm: add new test case of API saImmOmClassDelete()
> of apitest [#2951]
>
> ---
> .../apitest/management/test_saImmOmClassCreate_2.c | 4 ++++
> src/imm/apitest/management/test_saImmOmClassDelete.c | 19
> +++++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> b/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> index ea4db45..d8810e9 100644
> --- a/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> +++ b/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> @@ -1517,6 +1517,7 @@ extern void saImmOmClassDelete_2_01(void);
> extern void saImmOmClassDelete_2_02(void);
> extern void saImmOmClassDelete_2_03(void);
> extern void saImmOmClassDelete_2_04(void);
> +extern void saImmOmClassDelete_2_05(void);
>
> __attribute__((constructor)) static void
saImmOmInitialize_constructor(void)
> {
> @@ -1627,6 +1628,9 @@ __attribute__((constructor)) static void
> saImmOmInitialize_constructor(void)
> test_case_add(
> 2, saImmOmClassDelete_2_04,
> "saImmOmClassDelete_2 - SA_AIS_ERR_INVALID_PARAM, Empty
> classname");
> + test_case_add(
> + 2, saImmOmClassDelete_2_05,
> + "saImmOmClassDelete_2 - SA_AIS_ERR_NOT_EXIST ");
[Vu] Please add a slogan for this test case. A suggestion "Double delete a
class name"
>
> test_case_add(
> 2, saImmOmClassCreate_SchemaChange_2_01,
> diff --git a/src/imm/apitest/management/test_saImmOmClassDelete.c
> b/src/imm/apitest/management/test_saImmOmClassDelete.c
> index 273d192..ad36b8f 100644
> --- a/src/imm/apitest/management/test_saImmOmClassDelete.c
> +++ b/src/imm/apitest/management/test_saImmOmClassDelete.c
> @@ -76,3 +76,22 @@ void saImmOmClassDelete_2_04(void)
> test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> }
> +
> +void saImmOmClassDelete_2_05(void)
> +{
> + const SaImmClassNameT className = (SaImmClassNameT)
> __FUNCTION__;
> + SaImmAttrDefinitionT_2 attr1 = {"rdn", SA_IMM_ATTR_SANAMET,
> + SA_IMM_ATTR_CONFIG |
> SA_IMM_ATTR_RDN,
> + NULL};
> + const SaImmAttrDefinitionT_2 *attrDefinitions[] = {&attr1, NULL};
> +
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + safassert(immutil_saImmOmClassCreate_2(immOmHandle,
> className,
> + SA_IMM_CLASS_CONFIG,
attrDefinitions),
> + SA_AIS_OK);
> + immutil_saImmOmClassDelete(immOmHandle, className);
[Vu] Should add an assertion for the first delete to make sure the class has
been successfully deleted.
> + rc = immutil_saImmOmClassDelete(immOmHandle, className);
> + test_validate(rc, SA_AIS_ERR_NOT_EXIST);
> + safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> +}
> --
> 2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
