Hi Mohan,
Ack with a minor comment. Thanks.
Regards, Vu
> -----Original Message-----
> From: Mohan Kanakam <mo...@hasolutions.in>
> Sent: Friday, November 2, 2018 2:08 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
> <mo...@hasolutions.in>
> Subject: [PATCH 2/3] imm: add new test case of API
> saImmOmClassDescriptionGet_2() of apitest [#2951]
>
> ---
> .../apitest/management/test_saImmOmClassCreate_2.c | 3 +++
> .../management/test_saImmOmClassDescriptionGet_2.c | 25
> ++++++++++++++++++++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> b/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> index 9afbbe7..ea4db45 100644
> --- a/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> +++ b/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> @@ -1509,6 +1509,7 @@ extern void
> saImmOmClassDescriptionGet_2_02(void);
> extern void saImmOmClassDescriptionGet_2_03(void);
> extern void saImmOmClassDescriptionGet_2_04(void);
> extern void saImmOmClassDescriptionGet_2_05(void);
> +extern void saImmOmClassDescriptionGet_2_06(void);
> extern void saImmOmClassDescriptionMemoryFree_2_01(void);
> extern void saImmOmClassDescriptionMemoryFree_2_02(void);
>
> @@ -1604,6 +1605,8 @@ __attribute__((constructor)) static void
> saImmOmInitialize_constructor(void)
> test_case_add(
> 2, saImmOmClassDescriptionGet_2_05,
> "saImmOmClassDescriptionGet_2 - SA_AIS_OK, Fetch includes
> SA_IMM_ATTR_NO_DANGLING");
> + test_case_add(2, saImmOmClassDescriptionGet_2_06,
> + "saImmOmClassDescriptionGet_2 -
> SA_AIS_ERR_INVALID_PARAM");
[Vu] Lack of test slogan. A suggestion "Get class descriptor of an invalid
class name".
>
> test_case_add(2, saImmOmClassDescriptionMemoryFree_2_01,
> "saImmOmClassDescriptionMemoryFree_2 - SA_AIS_OK");
> diff --git
> a/src/imm/apitest/management/test_saImmOmClassDescriptionGet_2.c
> b/src/imm/apitest/management/test_saImmOmClassDescriptionGet_2.c
> index ecf7ceb..bada265 100644
> --- a/src/imm/apitest/management/test_saImmOmClassDescriptionGet_2.c
> +++ b/src/imm/apitest/management/test_saImmOmClassDescriptionGet_2.c
> @@ -175,3 +175,28 @@ void saImmOmClassDescriptionGet_2_05(void)
> safassert(immutil_saImmOmClassDelete(immOmHandle, className),
> SA_AIS_OK);
> safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> }
> +
> +void saImmOmClassDescriptionGet_2_06(void)
> +{
> + const SaImmClassNameT className = (SaImmClassNameT)
> __FUNCTION__;
> + SaImmAttrDefinitionT_2 attr1 = {
> + "rdn", SA_IMM_ATTR_SANAMET,
> + SA_IMM_ATTR_RUNTIME | SA_IMM_ATTR_RDN |
> SA_IMM_ATTR_CACHED, NULL};
> + const SaImmAttrDefinitionT_2 *attrDefinitionsIn[] = {&attr1, NULL};
> + SaImmClassCategoryT classCategory;
> + SaImmAttrDefinitionT_2 **attrDefinitionsOut;
> +
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + safassert(immutil_saImmOmClassCreate_2(immOmHandle,
> className,
> + SA_IMM_CLASS_RUNTIME,
> attrDefinitionsIn),
> + SA_AIS_OK);
> + rc = immutil_saImmOmClassDescriptionGet_2(immOmHandle, NULL,
> + &classCategory,
&attrDefinitionsOut);
> + test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> +
> safassert(immutil_saImmOmClassDescriptionMemoryFree_2(immOm
> Handle,
> + attrDefinitionsOut),
> + SA_AIS_OK);
> + safassert(immutil_saImmOmClassDelete(immOmHandle, className),
> SA_AIS_OK);
> + safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> +}
> --
> 2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
