changeset: 5394:19eea80e1f47
user: Gary Lee<[email protected]>
date: Tue Jun 17 11:55:06 2014 +0530
summary: amfd: Convert AVD_SI from struct to a class [#713]
changeset: 5395:2066588fc247
user: Gary Lee<[email protected]>
date: Tue Jun 17 11:56:00 2014 +0530
summary: amfd: Add constructor for AVD_SI [#713]
changeset: 5396:2656fae11b52
user: Gary Lee<[email protected]>
date: Tue Jun 17 11:56:40 2014 +0530
summary: amfd: Convert SI weights from char** to a vector of strings [#713]
changeset: 5397:489bafdc2f62
user: Gary Lee<[email protected]>
date: Tue Jun 17 11:57:16 2014 +0530
summary: amfd: Convert various SI static functions to class member
functions [#713]
changeset: 5398:fb62b2ea6c85
user: Gary Lee<[email protected]>
date: Tue Jun 17 11:58:01 2014 +0530
summary: amfd: Change avd_si_adjust_si_assignments to a member function
[#713]
changeset: 5399:149d943baeb4
user: Gary Lee<[email protected]>
date: Tue Jun 17 11:58:43 2014 +0530
summary: amfd: Change si_update_ass_state() from a static to a member
function of SI [#713]
changeset: 5400:d7ccd02863f8
user: Gary Lee<[email protected]>
date: Tue Jun 17 11:59:19 2014 +0530
summary: amfd: Remove unused function avd_si_remove_rankedsu() [#713]
changeset: 5401:fd0ad034cd5a
user: Gary Lee<[email protected]>
date: Tue Jun 17 12:00:30 2014 +0530
summary: amfd: Convert avd_si_admin_state_set to a AVD_SI member function
[#713]
changeset: 5402:43f3b7e899c5
user: Gary Lee<[email protected]>
date: Tue Jun 17 12:01:11 2014 +0530
summary: amfd: Fix whitespace problems in AVD_SI::set_admin_state [#713]
changeset: 5403:32dd10fe79cf
user: Gary Lee<[email protected]>
date: Tue Jun 17 12:01:38 2014 +0530
summary: amfd: Convert add_rankedsu and remove_rankedsu to member functions
[#713]
changeset: 5404:83f9cbf5387b
user: Gary Lee<[email protected]>
date: Tue Jun 17 12:02:07 2014 +0530
summary: amfd: Convert set_si_switch from a macro to member function [#713]
changeset: 5405:66f4f7572280
user: Gary Lee<[email protected]>
date: Tue Jun 17 12:02:51 2014 +0530
summary: amfd: move svctype and svctypecstype declarations to separate
files [#713]
changeset: 5406:d932b834569b
user: Gary Lee<[email protected]>
date: Tue Jun 17 12:03:30 2014 +0530
summary: amfd: Move sirankedsu declarations to its own header file [#713]
changeset: 5407:7324e15042fd
tag: tip
user: Gary Lee<[email protected]>
date: Tue Jun 17 12:04:03 2014 +0530
summary: amfd: convert remaining macros in si.cc to functions [#713]
---
** [tickets:#713] AMF refactoring for 4.5**
**Status:** review
**Milestone:** 4.5.FC
**Created:** Fri Jan 10, 2014 07:05 AM UTC by Hans Feldt
**Last Updated:** Mon Jun 16, 2014 06:43 AM UTC
**Owner:** Hans Feldt
This is a 4.5 ticket for continued code re-factoring of the AMF service for
4.5. The work started with #94 in 4.4.
So far no really no C++ features has been used. Files has been renamed so that
the C++ compiler is used and new/delete is used instead of malloc/free (where
appropriate).
In this ticket it is time to make use of C++ features to get a more
maintainable and understandable code base. We should aim for many small changes
instead of few big ones.
An ordered list of things to work on:
1. Use bool which is a native type in C++ (and remove SaBoolT)
2. Reduce number of casts in the code (introduced because of C++ files)
2. Use stl::maps (instead of patricia trees)
3. Use stl::vector/list (instead of legacy/home made lists)
Other yet non prioritized items:
- Remove use of EDU and do direct encode/decode
- Clean run of google's cpplint on the code base
- Convert model derived C structs to classes and change functions into methods
- Change macros to (inline) methods
- Change bit fields (flags) to boolean attributes (see
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
- Use references instead of pointers
- ...
Non C++ related changes:
- split up long functions into smaller ones doing one things and not many
- use pmccabe complexity analysis to aid refactoring
- set a goal for pmccabe complexity
- use const as much as possible
- ...
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
