changeset: 5429:0a7e0ef14284
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:32 2014 +0200
summary: amfd: change SG func ptr si_func to method si_assign [#713]
changeset: 5430:7d5eb10a9d3f
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:33 2014 +0200
summary: amfd: change SG si_admin_down function ptr to method [#713]
changeset: 5431:43b99aa01e79
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:33 2014 +0200
summary: amfd: change SG si_swap function ptr to method [#713]
changeset: 5432:29b83475dc14
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:34 2014 +0200
summary: amfd: change SG sg_admin_down function ptr to method [#713]
changeset: 5433:7111e1ad6cbb
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:34 2014 +0200
summary: amfd: change SG su_insvc function ptr to method [#713]
changeset: 5434:12bb1a9aaaed
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:35 2014 +0200
summary: amfd: change SG su_fault function ptr to method [#713]
changeset: 5435:23238cfb1710
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:35 2014 +0200
summary: amfd: change SG su_admin_down function ptr to method [#713]
changeset: 5436:60faecaaaafa
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:36 2014 +0200
summary: amfd: change SG susi_success function ptr to method [#713]
changeset: 5437:7e1955fb4b65
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:36 2014 +0200
summary: amfd: change SG susi_failed function ptr to method [#713]
changeset: 5438:b3abedc5f8ac
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:38 2014 +0200
summary: amfd: remove SG red model specific init [#713]
changeset: 5439:ec5147693bd5
tag: tip
user: Hans Feldt <[email protected]>
date: Thu Jun 26 06:19:38 2014 +0200
summary: amfd: add SG methods similar to existing macros [#713]
---
** [tickets:#713] AMF refactoring for 4.5**
**Status:** review
**Milestone:** 4.5.FC
**Created:** Fri Jan 10, 2014 07:05 AM UTC by Hans Feldt
**Last Updated:** Tue Jun 17, 2014 06:59 AM UTC
**Owner:** Hans Feldt
This is a 4.5 ticket for continued code re-factoring of the AMF service for
4.5. The work started with #94 in 4.4.
So far no really no C++ features has been used. Files has been renamed so that
the C++ compiler is used and new/delete is used instead of malloc/free (where
appropriate).
In this ticket it is time to make use of C++ features to get a more
maintainable and understandable code base. We should aim for many small changes
instead of few big ones.
An ordered list of things to work on:
1. Use bool which is a native type in C++ (and remove SaBoolT)
2. Reduce number of casts in the code (introduced because of C++ files)
2. Use stl::maps (instead of patricia trees)
3. Use stl::vector/list (instead of legacy/home made lists)
Other yet non prioritized items:
- Remove use of EDU and do direct encode/decode
- Clean run of google's cpplint on the code base
- Convert model derived C structs to classes and change functions into methods
- Change macros to (inline) methods
- Change bit fields (flags) to boolean attributes (see
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
- Use references instead of pointers
- ...
Non C++ related changes:
- split up long functions into smaller ones doing one things and not many
- use pmccabe complexity analysis to aid refactoring
- set a goal for pmccabe complexity
- use const as much as possible
- ...
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
