changeset: 5492:26857db654d4
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:17:59 2014 +0530
summary: amfd: Change more SI functions to class member functions [#713]
changeset: 5493:68f75e9392d4
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:18:45 2014 +0530
summary: amfd: Convert si_add_to_model to a member function [#713]
changeset: 5494:c21dd67fc485
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:19:17 2014 +0530
summary: amfd: replace SI decode routines with simple decode [#713]
changeset: 5495:0f4f2f21b323
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:19:42 2014 +0530
summary: amfd: replace SI encode routines with simple encode [#713]
changeset: 5496:6b4fd1388e0c
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:20:19 2014 +0530
summary: amfd: Refactor add_csi() and remove_csi() so they access SI
through 'this' ptr [#713]
changeset: 5497:32e6329c52cb
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:20:49 2014 +0530
summary: amfd: change avd_si_arrange_dep_csi to a member function [#713]
changeset: 5498:5b858ffb018f
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:21:13 2014 +0530
summary: amfd: change avd_si_add_csi_db to a member function [#713]
changeset: 5499:06f9a554068d
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:21:46 2014 +0530
summary: amfd: Change AVD_APP to a class [#713]
changeset: 5500:a15c36164935
tag: tip
user: Gary Lee<[email protected]>
date: Thu Jul 31 10:22:16 2014 +0530
summary: amfd: Change various AVD_APP functions to member functions [#713]
[staging:26857d]
[staging:68f75e]
[staging:c21dd6]
[staging:0f4f2f]
[staging:6b4fd1]
[staging:32e632]
[staging:5b858f]
[staging:06f9a5]
[staging:a15c36]
---
** [tickets:#713] AMF refactoring for 4.5**
**Status:** review
**Milestone:** 4.5.FC
**Created:** Fri Jan 10, 2014 07:05 AM UTC by Hans Feldt
**Last Updated:** Thu Jul 24, 2014 11:09 AM UTC
**Owner:** Hans Feldt
This is a 4.5 ticket for continued code re-factoring of the AMF service for
4.5. The work started with #94 in 4.4.
So far no really no C++ features has been used. Files has been renamed so that
the C++ compiler is used and new/delete is used instead of malloc/free (where
appropriate).
In this ticket it is time to make use of C++ features to get a more
maintainable and understandable code base. We should aim for many small changes
instead of few big ones.
An ordered list of things to work on:
1. Use bool which is a native type in C++ (and remove SaBoolT)
2. Reduce number of casts in the code (introduced because of C++ files)
2. Use stl::maps (instead of patricia trees)
3. Use stl::vector/list (instead of legacy/home made lists)
Other yet non prioritized items:
- Remove use of EDU and do direct encode/decode
- Clean run of google's cpplint on the code base
- Convert model derived C structs to classes and change functions into methods
- Change macros to (inline) methods
- Change bit fields (flags) to boolean attributes (see
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
- Use references instead of pointers
- ...
Non C++ related changes:
- split up long functions into smaller ones doing one things and not many
- use pmccabe complexity analysis to aid refactoring
- set a goal for pmccabe complexity
- use const as much as possible
- ...
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
