changeset: 5573:be8a60c92479
tag: tip
user: Hans Feldt <[email protected]>
date: Tue Aug 12 13:45:21 2014 +0200
summary: amfd: use set_adjust_state method [#713]
changeset: 5572:eb6971ade203
user: Hans Feldt <[email protected]>
date: Tue Aug 12 13:45:20 2014 +0200
summary: amfd: use set_fsm_state method in NORED [#713]
changeset: 5571:7f2c7a05b03b
user: Hans Feldt <[email protected]>
date: Tue Aug 12 13:45:19 2014 +0200
summary: amfd: use operlist methods in NORED [#713]
changeset: 5570:cd7bb10cbe7a
user: Hans Feldt <[email protected]>
date: Tue Aug 12 13:45:18 2014 +0200
summary: amfd: add SG methods for operlist manipulation [#713]
changeset: 5569:acb00eaf9908
user: Hans Feldt <[email protected]>
date: Tue Aug 12 13:45:17 2014 +0200
summary: amfd: change remaining NORED func into method [#713]
changeset: 5568:6ee7b08ba50a
parent: 5566:f2a3dbd5cb3f
user: Hans Feldt <[email protected]>
date: Tue Aug 12 13:45:16 2014 +0200
summary: amfd: change 2N FSM functions to methods [#713]
---
** [tickets:#713] AMF refactoring for 4.5**
**Status:** review
**Milestone:** 4.5.FC
**Created:** Fri Jan 10, 2014 07:05 AM UTC by Hans Feldt
**Last Updated:** Fri Aug 08, 2014 09:59 AM UTC
**Owner:** Hans Feldt
This is a 4.5 ticket for continued code re-factoring of the AMF service for
4.5. The work started with #94 in 4.4.
So far no really no C++ features has been used. Files has been renamed so that
the C++ compiler is used and new/delete is used instead of malloc/free (where
appropriate).
In this ticket it is time to make use of C++ features to get a more
maintainable and understandable code base. We should aim for many small changes
instead of few big ones.
An ordered list of things to work on:
1. Use bool which is a native type in C++ (and remove SaBoolT)
2. Reduce number of casts in the code (introduced because of C++ files)
2. Use stl::maps (instead of patricia trees)
3. Use stl::vector/list (instead of legacy/home made lists)
Other yet non prioritized items:
- Remove use of EDU and do direct encode/decode
- Clean run of google's cpplint on the code base
- Convert model derived C structs to classes and change functions into methods
- Change macros to (inline) methods
- Change bit fields (flags) to boolean attributes (see
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
- Use references instead of pointers
- ...
Non C++ related changes:
- split up long functions into smaller ones doing one things and not many
- use pmccabe complexity analysis to aid refactoring
- set a goal for pmccabe complexity
- use const as much as possible
- ...
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
