Hello Carsten and Gerrit,

 

back to OpenSG :-)

 

Attached you can find a patch file for some errors I have found. I have
created the patch file against the current master.

 

Could you please review my corrections and check them into the git
repository if they are fine.

 

I have found the following problems:

1. OSGShaderCache: Usage of incorrect end iterator types

2. OSGShaderCacheTree.inl: The ShaderCacheTreeV3::sub() method is imho
incorrect. The ShaderCache::clear() function currently does not work
properly. I was facing references to already destroyed ShaderCache
objects from ShaderProgramVariableChunks.

3. OSGShaderCacheTree.inl: Minor issue with the dumpDot function.

4. OSGShaderProgamVariableChunk.cpp: Imho, the resolveLinks function
should clear the _mfDestroyedFunctors container (?).  

 

Best,

Johannes

 

Attachment: original.patch
Description: original.patch

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users

Reply via email to