Hello Johannes,
On 02/06/2015 07:15 AM, Johannes Brunen wrote:
> back to OpenSG :-)
welcome back :)
> Attached you can find a patch file for some errors I have found. I have
> created the patch file against the current master.
Thank you for the bug fixes!
> I have found the following problems:
>
> 1. OSGShaderCache: Usage of incorrect end iterator types
applied.
> 2. OSGShaderCacheTree.inl: The ShaderCacheTreeV3::sub() method is imho
> incorrect. The ShaderCache::clear() function currently does not work
> properly. I was facing references to already destroyed ShaderCache
> objects from ShaderProgramVariableChunks.
I'll hold off applying this one for a couple of days so that either
Gerrit has a chance to comment or I can read up on how the cache works.
From you description it sounds like you have found the source of some
mysterious (and hard to find) bugs that have come up over time. Thanks
for finding this one!
> 3. OSGShaderCacheTree.inl: Minor issue with the dumpDot function.
applied.
> 4. OSGShaderProgamVariableChunk.cpp: Imho, the resolveLinks function
> should clear the _mfDestroyedFunctors container (?).
Agreed, it should be cleared. Applied.
Cheers,
Carsten
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users
