Hello Johannes,

On 07/13/2016 06:41 AM, Johannes wrote:
> You can find a patch file that contains the CMake build system
> adaptation for AntTweakBar on Wikisend:

thanks! I've committed the AntTweakBar related changes.

> Besides, it contains additional changes to CMake build system in order
> to support some other libraries.
>
> 1. I added the Qhull library. Currently it is not used at all, but I'm
> planning to use it in the OpenSG Base library in the near future.
>
> Link: http://www.qhull.org/
>       https://github.com/qhull/qhull/wiki

hmm, to me in general it is preferable to add dependencies when they are 
used...

> 2. I added the glm and vmath libraries. I do not intend to use them in
> any OpenSG libraries nor in any example, but here and then I use them in
> my examples for testing some code fragments. They are used a lot in the
> OpenGL community and sometimes it is quite useful to have them at hand.
> If the libraries are not present nothing awful will be happen. I would
> really appreciate support for these. The changes are really minimal.

Perhaps I'm misunderstanding something, but if the code is not going 
into OpenSG or examples why does the build system have to know about 
these libs in the first place? If it's just for something you are 
hacking on it seems easier to just hardcode the include path into the 
cmake file - especially given that these libraries seem to be header 
only. Anyway, if you feel strongly about this let me know and we can add 
them.

        Cheers,
                Carsten

------------------------------------------------------------------------------
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users

Reply via email to