I think my comments are on the border line between architecture review 
and design or code review, the only reason I'm asking is the $PATH issues.

Glenn Fowler wrote:
> the upshot is that, on solaris, ksh first looks for plugins for the
> "ksh" application, so the "ksh" "cmd" plugin, with solaris physical name
> "libcmd.so[optional-version]", could reside in
>       ../lib/ksh/libcmd.so[optional-version]
> somewhere on $PATH and

Do you really mean $PATH ?  If so that seems a bit strange since if I 
understand correctly you are dlopen()ing this so if any variables are 
used I would have expected them to be the $LD_* ones which you shouldn't 
interpret yourself but let ld.so.1 do for you.

>       builtin -f cmd
> will find the first one with the newest version (or with specific version
> constraints depending on how ksh coded the load plugin call)

Does the code explicitly look for libcmd.so.1 libcmd.so.2 etc or does it 
just assume that libcmd.so is the most recent ?  In the general case 
multiple copies of the same library at a different "version" don't 
actually work very well (it is a very complex problem area and has all 
sorts of nasty interactions but in this simple case it might be okay).

-- 
Darren J Moffat

Reply via email to