On 04/16/2014 01:56 PM, Dan Smith wrote: >> Do we really want to -1 for spelling mistake in nova-specs? > > I do, yes. These documents are intended to be read by deployers and > future developers. I think it's really important that they're useful in > that regard. > >> This is really a bad news for non-native speaker like me because I'm >> really not sensitive to the spelling even after checking again and >> again. > > Well, I certainly understand it can be frustrating. When I do it, I > provide the proper spelling in my comment, and I think I've been > generally pretty responsive to re-reviewing things quickly when it was > just a spelling error. Usually, however, there is something else to go > wrong with the -1 so it needs to be respun anyway.
Agreed. Hopefully most things can be caught with a spell check tool. I do think we should be lenient on minor grammar issues, unless the mistake is serious enough to impact understanding. -- Russell Bryant _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev