> Samuli Seppänen wrote: > >> From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001 >> From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= <sam...@openvpn.net> >> Date: Fri, 12 Nov 2010 17:32:19 +0200 >> Subject: [PATCH] Removed hardcoded signtool dependency from win/build_all.py >> >> Modified win/build_all.py so that build does not fail even if the optional >> signtool python class is not available. >> > > What is it needed for? Is it really *always* optional? Maybe some > setting or parameter to the script so that build can fail e.g. at > openvpn.net if building, where signing should always be done? > > > //Peter > As far as I know driver signing is supposed to be optional. From "win/settings.in":
# Code Signing. # If undefined, don't sign any files. !define SIGNTOOL "../signtool" !define PRODUCT_SIGN_CN "openvpn" This "settings.in" contains many other variables used by the Python-based build system. Looking at the comments one would think that simply disabling the the SIGNTOOL variable would allow non-signed builds. This is not the case, hence the patch. I'm as open as it gets to suggestions how to make the patch better, though :). -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
