Hi Peter, Fair points. Me fix and resend.
-- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Samuli Seppänen wrote: > >> here's the next version of the patch; >> > > Functionally fine! > > > >> def main(config): >> + >> + # Do a signed build by default >> + unsignedBuild=False >> > > Maybe name the option signedBuild instead? :) > > > >> + # Check if the SignTool module is present. This avoids ImportErrors >> popping >> + # up annoyingly _after_ the build. >> + if unsignedBuild == False: >> + try: >> + from signtool import SignTool >> + except (ImportError): >> + print "ERROR: SignTool python module not found! Can't do a signed >> build." >> + sys.exit(1) >> + >> + if unsignedBuild == True: >> + print "Doing an unsigned build as requested" >> > > I guess the pythonic way would be simply: > > if signedBuild: > try import.. > else: > print as requested.. > > > >> - sign(config, 'all') >> + >> + if unsignedBuild == False: >> + sign(config, 'all') >> + >> > > signedBuild would be nicer, then simply: > > if signedBuild: > sign() > > > //Peter > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today > http://p.sf.net/sfu/msIE9-sfdev2dev > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel >
