So the vote goes clearly to #defines, right?
I'm going to change the code and test it. If it works, the change will be included in the next patch. Best regards, Holger Am 18.06.2014 23:07, schrieb David Sommerseth:
I see and understands the arguments for using static const, and it surely have it's advantages. However, the OpenVPN code base, which dates back over a decade, has used the #define approach. This is probably one of the really few things where the code base is quite consistent. I prefer that we try to be somewhat consistent with what most of the already existing code uses. Even though the coding style can be quite inconsistent in parts of the code base, I prefer that we don't add more inconsistency. If we at some point find the advantages with static const to really be superior to #define, then we should switch most of the code base to that style. But that's a different discussion, as this just as well requires compatibility testing with preprocessors and compilers across several platforms.
