On 9 December 2016 at 21:43, Selva Nair <selva.n...@gmail.com> wrote:
> On Fri, Dec 9, 2016 at 8:41 AM, Steffan Karger <stef...@karger.me> wrote:
>> On 9 December 2016 at 00:14, David Sommerseth
>> <open...@sf.lists.topphemmelig.net> wrote:
>> > I just spotted in ssl.c that we need sp_assign=add.
>> >
>> > [ ssl.c, tls1_PRF() ]
>> >     len = slen/2;
>> >     S1 = sec;
>> >     S2 = &(sec[len]);
>> >     len += (slen&1); /* add for odd, make longer */
>> >
>> > I believe we've agreed on spaces around assignments.
>> Hm, I'd be fine with that, but I'm afraid there are too many such
>> details to bikeshed about.  Once we've fixed the curious newlines
>> Selva mentionded (sorry, not sure when I can look at that), I think we
>> should stop the discussion and move forward.  Just 5 more days until
>> rc2 (where the reformatting should be done).
> Agreed.  I'll make no more noise :)
> To troubleshoot the extra newlines in places like line 130 of the file you
> uploaded
> https://paste.fedoraproject.org/502063/36953148
> I ran uncrustify using the options listed at our CodeStyle page and all look
> good and nice. No such extra newlines. By the way sp_between_byref is not a
> valid option.

Hm, indeed.  Must have been an artifact of running uncrustify multiple
times or something like that.  I removed sp_between_byref.

Sounds like we have a final config on the CodeStyle page now.  Are we
ready to run it on all code now, and publish a reformat branch?


Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
Openvpn-devel mailing list

Reply via email to