On 22/09/17 23:25, Gert Doering wrote: > Hi, > > On Thu, Sep 07, 2017 at 03:16:45PM +0200, David Sommerseth wrote: >> So the RestartForceExitStatus/RestartPreventExitStatus is not going to >> be helpful if all graceful errors results in 1, which is the most common >> way OpenVPN stops - through the M_FATAL. So that leaves us with >> SIGSEGV, SIGABRT and similar unclean exit signals. >> >> To avoid restarts on faulty configurations or if we can define scenarios >> where we do not want OpenVPN to be restarted automatically, we need to >> introduce more exit codes. This way we can implicitly tell systemd if >> it should restart OpenVPN or not. > > Indeed. Just to agree publically here :-) - it seems we'll need to > revisit exit codes as well, for "restarting this won't do any good" > (fatal config errors, for example) vs. "we have crashed, and please do > restart!!" (out of memory as something obvious we can't easily catch, > most other error situations wrt network *should* not cause a M_FATAL, > even if some still do). > > Where do we keep this as "we need to look into it, but it's complicated" > reminder? trac?
Yeah, a trac ticket is probably the best. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
