Acked-by: Gert Doering <g...@greenie.muc.de>

Stared at the code (twice now), run t_client and t_server tests.

This patch does not really *do* much yet, but it lays the groundwork
for future work - the "broadcast only to clients in the same vlan"
part is there, but it's always called with "0" (= all clients).  As
far as I can see, the only notable behavioural change we have so far 
is "if a client is assigned a pvid (!= the global pvid), it will not 
be able to communicate with the TAP interface" (check in vlan.c, 
vlan_process_outgoing_tun()), but client-to-client is still allowed,
and there is no per-vlan MAC learning yet either.

(Most notably, it only adds options and code relevant for TAP mode)

Your patch has been applied to the master branch.

commit 99f28081477ca325a14b13c38abec2c9b619eb01
Author: Antonio Quartulli
Date:   Wed Oct 9 16:34:15 2019 +0200

     VLAN: add basic VLAN tagging support

     Signed-off-by: Fabian Knittel <fabian.knit...@lettink.de>
     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20191009143422.9419-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18924.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to