Hi,
On Thu, Apr 16, 2020 at 01:39:28PM +0200, Arne Schwabe wrote:
> index 18a86ceb..dadf0a90 100644
> --- a/src/openvpn/crypto.h
> +++ b/src/openvpn/crypto.h
> @@ -528,21 +528,7 @@ void crypto_read_openvpn_key(const struct key_type
> *key_type,
> * As memcmp(), but constant-time.
> * Returns 0 when data is equal, non-zero otherwise.
> */
> -static inline int
> -memcmp_constant_time(const void *a, const void *b, size_t size)
> -{
Not sure I understand the motivation for this change. "Just so uncrustify
stops trying to change this" is not really strong.
Also, keeping the "inline" part would be good... this is in the per-packet
path.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
