Hi,
On Fri, Apr 17, 2020 at 03:42:49PM +0200, Antonio Quartulli wrote:
> >> -static inline int
> >> -memcmp_constant_time(const void *a, const void *b, size_t size)
> >> -{
> >
> > Not sure I understand the motivation for this change. "Just so uncrustify
> > stops trying to change this" is not really strong.
>
> well, sometimes to adhere to the codestyle, you have to re-arrange code :)
"rearrange" and "rewrite in a not easy to understand way" (which looks
a bit overthought to me, TBH - unlike "secure memzero" I cannot see an
obvious reason why all that volatile would be relevant).
> On top of that, this is basically allowing us to re-use an existing
> openssl API when possible.
True, but if that turns out to be a code complication and reduces
efficiency, I'm not convinced it's the right way to spend our cycles.
> > Also, keeping the "inline" part would be good... this is in the per-packet
> > path.
>
> I am not sure it would work in this case, because the function is
> defined in a .c file now - it's not inlineable anymore outside of the
> mbedtls code.....
This is why I'm not exactly happy with the change.
We could do it "openvpn style" all in header files, or we could just
leave the function alone.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
