On 17/04/2020 10:51, Gert Doering wrote:
> Hi,
>
> On Thu, Apr 16, 2020 at 01:39:28PM +0200, Arne Schwabe wrote:
>> index 18a86ceb..dadf0a90 100644
>> --- a/src/openvpn/crypto.h
>> +++ b/src/openvpn/crypto.h
>> @@ -528,21 +528,7 @@ void crypto_read_openvpn_key(const struct key_type
>> *key_type,
>> * As memcmp(), but constant-time.
>> * Returns 0 when data is equal, non-zero otherwise.
>> */
>> -static inline int
>> -memcmp_constant_time(const void *a, const void *b, size_t size)
>> -{
>
> Not sure I understand the motivation for this change. "Just so uncrustify
> stops trying to change this" is not really strong.
well, sometimes to adhere to the codestyle, you have to re-arrange code :)
On top of that, this is basically allowing us to re-use an existing
openssl API when possible.
>
> Also, keeping the "inline" part would be good... this is in the per-packet
> path.
I am not sure it would work in this case, because the function is
defined in a .c file now - it's not inlineable anymore outside of the
mbedtls code.....
Regards,
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
