Acked-by: Gert Doering <g...@greenie.muc.de> I think this is a useful addition. Code looks good according to the documentation for CertGetNameStringW() and WideCharToMultiByte().
Tested on a MinGW compile (yes, compiles :-) ). Not actually tested on a life windows system, as my "have p12 certs imported, reference them from .ovpn" project is still pending. The 3 new gc_free() are a bit ugly, but unavoidable without either having "gc_free() in the middle of the function" (which we don't do) or restructure more & add "ret = 1 ; goto end" code... so it is what it is. Your patch has been applied to the master and release/2.6 branch. commit ddffcea2922905ec13e0e39239d106e0edbea5de (master) commit 0ccfce24b470d924d4184c8a3de08a50154c5e4c (release/2.6) Author: Selva Nair Date: Sat Jan 28 17:34:19 2023 -0500 cyryptapi.c: log the selected certificate's name Signed-off-by: Selva Nair <selva.n...@gmail.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20230128223421.2207802-3-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26093.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel