Acked-by: Gert Doering <[email protected]>
I did hope that someone else would report back and say "I have tested this
and it works great!". Nobody volunteered and I wanted this out of the
way (and I think it's a useful addition with very little code needed).
Code looks good according to documentation of CertFindCertificateInStore()
(though the microsoft documentation I found lacks the CERT_FIND...*_W
defines... but it's symmetric to CERT_FIND_SUBJECT_STR_W)
MinGW and GH tell me that the code compiles fine :-)
Documentation addition is good and well-understandable.
Your patch has been applied to the master and release/2.6 branch.
commit b9e0e4060798ed88d2170702f2935754616b1200 (master)
commit a8ff15ce49b69816b64387e3387b9a310891d12a (release/2.6)
Author: Selva Nair
Date: Sat Jan 28 17:34:18 2023 -0500
Option --cryptoapicert: support issuer name as a selector
Signed-off-by: Selva Nair <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg26092.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel