Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 2: Code-Review-1 (6 comments) File tests/lwip_client_up.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/1843a1b0_52ead016 : PS2, Line 20: echo "Waiting for fping to exit ($count/$maxcount)" mixed indent over the next three lines File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/c505db89_06e4ea15 : PS2, Line 6: if echo "$test_name"|grep _lwip > /dev/null 2>&1; then is "grep -q" portable? That would be nicer here. http://gerrit.openvpn.net/c/openvpn/+/811/comment/81b73860_900e7d09 : PS2, Line 8: return 1 tab indent http://gerrit.openvpn.net/c/openvpn/+/811/comment/2d16907b_24ca5a14 : PS2, Line 41: return 0 tab indent http://gerrit.openvpn.net/c/openvpn/+/811/comment/ae1b215d_2f625303 : PS2, Line 162: if test -r ./lwipovpn; then Would be nice to be able to override this with something like `$LWIPOVPN`. Definitely do not want to copy that executable around all the time. http://gerrit.openvpn.net/c/openvpn/+/811/comment/b99be658_67323adc : PS2, Line 189: if echo "$test_name"|grep _lwip > /dev/null; then another case for grep -q -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 2 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Thu, 21 Nov 2024 17:20:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
