Attention is currently required from: flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 4: (7 comments) Patchset: PS4: All issues resolved. File tests/lwip_client_up.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/e5dfa19e_fca0a793 : PS2, Line 20: echo "Waiting for fping to exit ($count/$maxcount)" > mixed indent over the next three lines Done File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/1acb5cc3_d3a479e7 : PS2, Line 6: if echo "$test_name"|grep _lwip > /dev/null 2>&1; then > is "grep -q" portable? That would be nicer here. Done http://gerrit.openvpn.net/c/openvpn/+/811/comment/c6345891_2ea42088 : PS2, Line 8: return 1 > tab indent Done http://gerrit.openvpn.net/c/openvpn/+/811/comment/7d51432a_fcba8233 : PS2, Line 41: return 0 > tab indent Done http://gerrit.openvpn.net/c/openvpn/+/811/comment/55e97910_8cd840bb : PS2, Line 162: if test -r ./lwipovpn; then > Would be nice to be able to override this with something like `$LWIPOVPN`. […] It is now possible to do LWIPOVPN_PATH=/some/path/to/lwipovpn make check To use a custom location. It would have been nicer to be able to override it it t_server_null.rc, but that file gets loaded too late for it to have any practical effect on the actual client command-lines. http://gerrit.openvpn.net/c/openvpn/+/811/comment/1078467a_e03e2968 : PS2, Line 189: if echo "$test_name"|grep _lwip > /dev/null; then > another case for grep -q Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 4 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 13:05:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
