Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 4: Code-Review-2 (3 comments) File doc/t_server_null.rst: http://gerrit.openvpn.net/c/openvpn/+/811/comment/cfcc4062_edab2a5a : PS4, Line 129: Note that all ovpnlwip test names need to include a "_lwip" suffix: without if "without it" File tests/lwip_client_up.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/a46c4c72_23d0241a : PS4, Line 4: if ! grep "$ifconfig_local" ./$test_name.ips; then Should use grep -q File tests/t_server_null_default.rc: http://gerrit.openvpn.net/c/openvpn/+/811/comment/d4f73210_6228eae2 : PS4, Line 22: LWIPOVPN_PATH="${LWIPOVPN_PATH:-lwipovpn}" This is extremely misleading. This seems to indicate that you can override `LWIPOVPN_PATH`. However you can definitely not do so in t_server_null.rc since that is loaded after t_server_null_default.rc and it is too late. Even more when you set LWIPOVPN_PATH in t_server_null.rc it actually allows to start the lwip tests since the test whether lwipovpn is available does use the updated LWIPOVPN_PATH. We either need to clearly define that LWIPOVPN_PATH can not be overridden or we need to fix it so that it can. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 4 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Wed, 08 Jan 2025 14:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
